Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use double brackets for proxy url template #42

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Use double brackets for proxy url template #42

merged 1 commit into from
Jan 18, 2022

Conversation

benz0li
Copy link

@benz0li benz0li commented Jan 18, 2022

This PR resolves coder/code-server#1510 (comment): @code-asher Double brackets may be used now to match VS Code's own templating scheme.

REditorSupport/vscode-R#934 has been accepted and released with R Extension v2.3.6.

Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huzzah! Thank you for this!

@code-asher code-asher merged commit 5f069ef into coder:main Jan 18, 2022
jsjoeio added a commit to coder/code-server that referenced this pull request Feb 11, 2022
This includes two fixes from coder/vscode:
- coder/vscode#43
- coder/vscode#42
jsjoeio added a commit to coder/code-server that referenced this pull request Feb 15, 2022
* chore: update vscode commit

This includes two fixes from coder/vscode:
- coder/vscode#43
- coder/vscode#42

* fix: use double-bracket in ext. e2e test
TinLe pushed a commit to TinLe/code-server that referenced this pull request Apr 23, 2022
* chore: update vscode commit

This includes two fixes from coder/vscode:
- coder/vscode#43
- coder/vscode#42

* fix: use double-bracket in ext. e2e test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set environment variable VSCODE_PROXY_URI
2 participants