Skip to content

Remove dependency on golang.org/x #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nhooyr opened this issue Sep 3, 2019 · 5 comments · Fixed by #135
Closed

Remove dependency on golang.org/x #134

nhooyr opened this issue Sep 3, 2019 · 5 comments · Fixed by #135

Comments

@nhooyr
Copy link
Contributor

nhooyr commented Sep 3, 2019

See #128 (comment)

Would be nice to be truly zero dep.

Right now we depend on httpguts and xerrors.

xerrors can be easily removed now that Go 1.13 is out. Only problem is no frame information anymore which is unfortunate but welp

For httpguts I think it can be easily removed too.

@andersfylling
Copy link

Will you be doing v2 release once this closes?

@nhooyr
Copy link
Contributor Author

nhooyr commented Sep 3, 2019

I'll release v1.5.1. I don't think we need to release a v2, xerrors and stdlib errors are fully compatible.

@coadler
Copy link
Contributor

coadler commented Sep 3, 2019

The frame information not making it into std is a big bummer.

@andersfylling
Copy link

You can actually use xerrors on go1.13 errors?

@nhooyr
Copy link
Contributor Author

nhooyr commented Sep 3, 2019

Yes, it's all based on interfaces so should just work.

nhooyr added a commit that referenced this issue Sep 3, 2019
nhooyr added a commit that referenced this issue Sep 4, 2019
nhooyr added a commit that referenced this issue Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants