Skip to content

CloseError wrapping #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pymq opened this issue Oct 7, 2019 · 1 comment · Fixed by #160
Closed

CloseError wrapping #161

pymq opened this issue Oct 7, 2019 · 1 comment · Fixed by #160
Labels

Comments

@pymq
Copy link

pymq commented Oct 7, 2019

I think there is a misspelling: %v instead of %w here.
My case is checking error from executing conn.Read() As websocket.CloseError and handle disconnection

@nhooyr
Copy link
Contributor

nhooyr commented Oct 7, 2019

So that's intended. See #103

#160 should help clear this up and make it more intuitive.

The idea is that you only want to check for a status code you receive from the peer but if you send a status code, you don't want to check for it, just error out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants