Skip to content

Convert echo example to plain echo server and test in a real Go test #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nhooyr opened this issue Apr 14, 2020 · 0 comments · Fixed by #224
Closed

Convert echo example to plain echo server and test in a real Go test #223

nhooyr opened this issue Apr 14, 2020 · 0 comments · Fixed by #224
Labels
enhancement

Comments

@nhooyr
Copy link
Contributor

nhooyr commented Apr 14, 2020

Right now we test in main. Worked when it was a godoc example but now we can demonstrate proper structure.
@nhooyr nhooyr changed the title Convert test example to plain echo server and test in a real Go test Convert echo example to plain echo server and test in a real Go test Apr 14, 2020
nhooyr added a commit that referenced this issue Apr 14, 2020
@nhooyr
Add automated test and documentation for echo example
55f4a70 
Closes #223
@nhooyr nhooyr mentioned this issue Apr 14, 2020
Merged
nhooyr added a commit that referenced this issue Apr 14, 2020
@nhooyr
Add automated test and documentation for echo example
c40b702 
Closes #223
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add automated test and documentation for echo example coder/websocket
1 participant
@nhooyr