Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NetConn leaks timers #243

Closed
ash2k opened this issue May 25, 2020 · 1 comment
Closed

NetConn leaks timers #243

ash2k opened this issue May 25, 2020 · 1 comment
Labels
bug
Milestone
v1.8.8

Comments

@ash2k
Copy link

ash2k commented May 25, 2020

Hey, first of all thanks a lot for NetConn()! I have written one myself, but then discovered this library and decided to use it instead.

I have noticed that netConn.Close() does not call Stop() on writeTimer and readTimer. I think it should at least if the deadlines have been set. Otherwise these timers are lingering around and that can be an issue if there are a lot of connections.
@nhooyr
Copy link
Contributor

nhooyr commented May 25, 2020

Great catch! Will fix soon.

@nhooyr nhooyr added the bug label May 25, 2020
@nhooyr nhooyr added this to the v1.8.7 milestone May 25, 2020
nhooyr added a commit that referenced this issue Jul 4, 2020
@nhooyr
netconn: Prevent timer leakage
5cac90d 
Closes #243
@nhooyr nhooyr mentioned this issue Jul 4, 2020
Merged
nhooyr added a commit that referenced this issue Jul 5, 2020
@nhooyr
netconn.go: Prevent timer leakage (#255)
493ebbe 
Closes #243
@nhooyr nhooyr closed this as completed Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v1.8.8
Development

No branches or pull requests
2 participants
@ash2k @nhooyr