Skip to content

Make errAlreadyWroteClose exported #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Antonboom opened this issue Apr 26, 2021 · 2 comments
Closed

Make errAlreadyWroteClose exported #300

Antonboom opened this issue Apr 26, 2021 · 2 comments

Comments

@Antonboom
Copy link

Hello!

I would like to get a mechanism to avoid unnecessary logging of the closing error:

	defer func() {
		err2 := wsConn.Close(websocket.StatusInternalError, "the sky is falling")
		if err2 != nil {
			logger.WithError(err2).Error("error on close websocket")
		}
	}()

Thanks.

@emersion
Copy link
Contributor

Related: #286

@nhooyr
Copy link
Contributor

nhooyr commented Aug 6, 2021

Thanks for reporting @Antonboom.

Yes as @emersion pointed out please follow #286 as the tracking issue for this.

And apologies for the delayed response!

@nhooyr nhooyr closed this as completed Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants