-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading broken due to vanity rename #464
Comments
Great point @andig Sorry for the trouble. Here's what we changed in response: nhooyr.io/websocket now points to https://github.com/nhooyr/websocket-old/releases/tag/v1.8.16 which is marked as deprecated at the package level & all exported symbols so that people know to transition off it. There will be no further updates or breakage on nhooyr.io/websocket github.com/coder/websocket is an entirely separate module now. Thanks for opening the issue. |
Thank you. Did a quick
This seems great, especially since https://nhooyr.io/websocket points to Coder now. Thank you for changing this so quickly and making developer's life a bit easier! |
From #462:
They are easily resolvable only by adding replace directives afaikt, at least if downstream modules depend on it. As a result, this will break everybody's go.mod and will make everybody wait for downstream updates. There is no obvious reason for pulling of the "band aid".
It would imho have been much better to not update the module name. Given it is a vanity name anyway there's absolutely no need for doing so. If a rename is needed it should be for a new start instead of breaking the vanity import.
I'd suggest to retract this version and decide either way. The current solution is the worst possible. At least the vanity import should continue forwarding to the old repo.
The text was updated successfully, but these errors were encountered: