Problem: NetConn wrapper kept canceling context #112
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: Accept the zero time as a special case when setting deadlines. Somehow, this function gets called without a time and thus would previously Reset the timer to no time at all, thus expediting the call to cancel the context.
|
Thank you so much @Vaelatern I've merged this as fb30712 and will tag a new release. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: Accept the zero time as a special case when setting
deadlines. Somehow, this function gets called without a time and thus
would previously Reset the timer to no time at all, thus expediting the
call to cancel the context.
Would close #111