-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite with compression support #163
Conversation
Memory usage is still a problem but I think this feature can still be useful in some cases and it is standard so might as well implement it given it doesn't add too much to the API. |
Thoughts on the API? @andersfylling @coadler @FZambia |
It's not relevant to my use-cases as I use gzip, I think(?). But looks easy enough to use. I would add a validation step on Treshold and Level field. |
Sounds good. Only issue I could forsee with this API is you can't control per message compression which I imagine is something people will want control over. But I'd have to break backwards compat and add a writer options structure to allow for that. Or maybe just a way to disable compression for an individual message (that may already have some other form of compression, e.g. a JPEG image) but keep the level and threshold global to the connection. 🤔 |
Also, I noticed Facebook uses per message deflate for their chat, which has very small message sizes. Could either be a oversight or an optimization, not sure. 🤔 |
14baab4
to
2a9e139
Compare
So it begins :)
Too many improvements and changes to list. Will include a detailed changelog for release.
https://tools.ietf.org/html/rfc7692