-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make compression negotiation more lenient #258
Conversation
d522d62
to
27d6747
Compare
The RFCs allow for some strange formatting of the extensions. For instance, the parameter values may be quoted (e.g. |
Thanks for contributing @abursavich! <3 Unfortunately I'm going to be a busy this week until the weekend. I'll try and review these changes then. Have a great rest of your week! |
825873c
to
9b5a15b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful, sorry for the delay.
Unacceptable offers are declined without rejecting the request.
Thanks @abursavich! |
I ran into a server this morning that was being extra-super-duper explicit and specifying
server_max_window_bits=15
, so I started digging into the RFC and the negotiation code... These are the changes I would like to make:server_max_window_bits
: The server may use a smaller sliding window for compression without affecting the client's decompression.server_max_window_bits=15
: Although the server can't support a smaller sliding window at the moment, it doesn't hurt to accept the specification of 15 bits from a client.x-webkit-deflate-frame
code.