Fix unaligned load error on 32-bit architectures #438
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some 32-bit architectures, 64-bit atomic operations panic when the value is not aligned properly.
In this package, this causes netConn operations to panic when compiling with
GOARCH=386
, since netConn does atomic operations with int64 values in the netConn struct (namely, with readExpired and writeExpired):This commit fixes this by moving readExpired and writeExpired to the beginning of the struct, which makes them properly aligned.
I didn't test, but I think this error will also occur on 32-bit ARM (Raspberry Pi Zero) and MIPS32 (a bunch of routers use that, which is a real use case for me), see https://pkg.go.dev/sync/atomic#pkg-note-BUG and grafana/loki#6944