-
Notifications
You must be signed in to change notification settings - Fork 312
Refactoring #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring #81
Conversation
Codecov Report
@@ Coverage Diff @@
## master #81 +/- ##
==========================================
- Coverage 82.35% 80.94% -1.41%
==========================================
Files 10 10
Lines 731 824 +93
==========================================
+ Hits 602 667 +65
- Misses 108 128 +20
- Partials 21 29 +8
Continue to review full report at Codecov.
|
Closes #78
This PR adds concurrent reads and massively simplifies the internals of the libraries 👏 |
Figured out a clever way to merge readLoop and timeoutLoop into a single goroutine! |
Nvm I did not, I thought io.Reader was non blocking but it isn't. It blocks for at least a single read usually. So if we combine the two, then there is no way to get readLoop to wake up. |
Don't want buggy code in master.
98bf7a1
to
4de9061
Compare
@coadler Definitely let me know how you feel about the additions to the API. |
👍 will take a look tomorrow morning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the additions.
(*Conn).Context
will be very helpful
I'll test these out on my gateway later this weekend and let you know anything else I find |
Closes #78