Skip to content

Pool buffers in wspb and wsjson #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2019
Merged

Pool buffers in wspb and wsjson #85

merged 1 commit into from
Jun 2, 2019

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Jun 2, 2019

Closes #71

@nhooyr nhooyr requested a review from coadler June 2, 2019 11:55
@nhooyr nhooyr force-pushed the poolbuf branch 2 times, most recently from 0a159bf to e85aa1d Compare June 2, 2019 12:01
@codecov
Copy link

codecov bot commented Jun 2, 2019

Codecov Report

Merging #85 into master will decrease coverage by 1.53%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #85      +/-   ##
=========================================
- Coverage   80.94%   79.4%   -1.54%     
=========================================
  Files          11      12       +1     
  Lines         871     879       +8     
=========================================
- Hits          705     698       -7     
- Misses        136     150      +14     
- Partials       30      31       +1
Impacted Files Coverage Δ
internal/bpool/bpool.go 0% <0%> (ø)
websocket.go 75.89% <0%> (-1.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 631c152...e9d8945. Read the comment docs.

@nhooyr nhooyr merged commit 3fc2087 into master Jun 2, 2019
@nhooyr nhooyr deleted the poolbuf branch June 2, 2019 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pool buffers in wspb/wsjson
1 participant