Skip to content

Add WebSocket masking and correctly use Sec-WebSocket-Key in client #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2019

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Jun 4, 2019

Closes #88

Thanks again for the bug report @propertyscott.

@codecov
Copy link

codecov bot commented Jun 4, 2019

Codecov Report

Merging #89 into master will decrease coverage by 1%.
The diff coverage is 81.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
- Coverage   79.72%   78.72%   -1.01%     
==========================================
  Files          14       14              
  Lines         957     1001      +44     
==========================================
+ Hits          763      788      +25     
- Misses        151      162      +11     
- Partials       43       51       +8
Impacted Files Coverage Δ
dial.go 86.66% <100%> (+1.66%) ⬆️
accept.go 88.76% <100%> (+0.12%) ⬆️
websocket.go 76.29% <75.47%> (-2.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4130a30...abcbea0. Read the comment docs.

@nhooyr nhooyr merged commit 169cdbc into master Jun 4, 2019
@nhooyr nhooyr deleted the sec branch June 4, 2019 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation should note that package ignores protection against untrusted client
1 participant