Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Droppable Future instead of TaskMetadata #4

Merged
merged 3 commits into from
Jul 20, 2024

Conversation

coder137
Copy link
Owner

  • TaskMetadata does not Drop when using tokio::select
  • Added tokio integration tests for join! and select!

Copy link

codecov bot commented Jul 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (07eda0e) to head (6cd106f).

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #4   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         3    +1     
  Lines           65        64    -1     
=========================================
- Hits            65        64    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coder137 coder137 merged commit f22d942 into main Jul 20, 2024
5 checks passed
@coder137 coder137 deleted the revert_metadata_commit branch July 20, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant