Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove global font setting for buttons (fix #32) #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pjeby
Copy link

@pjeby pjeby commented Mar 15, 2022

No description provided.

@coderaiser
Copy link
Owner

I think better to put this style under .smalltalk button

@pjeby
Copy link
Author

pjeby commented Mar 15, 2022

But then people will still have to override it to specify the font-family they want buttons to normally have, so that the buttons will by default match their global styling. Better to fall back to the application's fonts, to ensure compatibility with any i18n/a11y issues for fonts. (A library should really not be setting font families in required CSS, unless it's to use a specialized font like an icon library -- everyone will just end up having to override it with more-specific selectors, adding unnecessary overhead.)

@coderaiser
Copy link
Owner

In this case, would be great to check styles of Cloud Commander and make changes if needed, so everything worked as it was before modification.

Anyways you can always use !important keyword.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants