Error when including pattern

[kobiche]

Hey,

I just installed gitingest in my python 3.11 env and this happened:

> gitingest --include-pattern src\converter\
Error: cannot access local variable 'parsed_query' where it is not associated with a value
Aborted!

[jpotw]

Hey, I just tried cloning the main repo and everything worked perfectly on my WSL setup:

❯ git clone https://github.com/cyclotruc/gitingest.git
Cloning into 'gitingest'...
...
Resolving deltas: 100% (1137/1137), done.
❯ cd gitingest
❯ python3 -m venv venv
❯ source venv/bin/activate
❯ pip install -r requirements.txt
Collecting click>=8.0.0 (from -r requirements.txt (line 1))
...
websockets-15.0 wrapt-1.17.2
❯ pip install gitingest
Collecting gitingest
...
Successfully installed gitingest-0.1.3
❯ gitingest --include-pattern src\converter\
Analysis complete! Output written to: digest.txt
Summary:
Repository: jpotw/gitingest
Files analyzed: 0
Estimated tokens: 10

If you're having issues, maybe check:

1. Are you in the right directory?
2. Did you install gitingest properly? The current version should be 0.1.3

[kobiche]

I installed it using pip: pip install gitingest

[kobiche]

Oh, I think what's the problem. I am using Windows paths, ie. with backslashes.
I just tried changing that, and it worked.
Can you test it too?

(if that's the case, then it seems like it's really a bug)

[jpotw]

I am currently not available to use Python env in my Windows.. but it works fine with my WSL with backlashes.
Maybe it's how cli.py deals with backlashes, as you've mentioned.

[kobiche]

I cloned the repo and now I got to see where the error lies:
is_valid_pattern() checks if all the characters in a single pattern are valid. Why is this function necessary?

Example

>>> pattern
'.\\src\\gitingest'
>>> [c.isalnum() or c in "-_./+*@" for c in pattern]
[True, False, True, True, True, False, True, True, True, True, True, True, True, True, True]
>>> all(c.isalnum() or c in "-_./+*@" for c in pattern)
False

I'd suggest we include an or in this checker: all(c.isalnum() or c in "-_./+*@" for c in pattern) or Path(pattern).exists().
What do you think?

[filipchristiansen]

This PR adds support for Widows-style include patterns

• fix: fix directory include pattern matching and normalize Windows paths #217