fix: async_ingest concurrent repo cloning
#309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmnunez1993
changed the title
dmnunez1993
changed the title
filipchristiansen
changed the title
async_ingest concurrent repo cloning
|
@dmnunez1993 Thank you very much for this PR Also, the CI is failing, could you run |
Pedrexus
reviewed
Jun 26, 2025
cyclotruc
reviewed
Jul 1, 2025
|
@dmnunez1993 We were just missing the parent directory, I added it and merged, thanks a lot for your contrib! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue when using ingest_async as described in #261 by @Pedrexus.
This issue occurred because
TMP_BASE_PATHwas being completely removed after each repository was cloned. In an asynchronous context, multiple repositories can be cloned at the same time. IfTMP_BASE_PATHis deleted while another clone is still in progress, it can cause an error indicating that the target folder no longer exists.As an alternative,
query.local_pathis used. This folder is created during the initial parse of the repository, and has a unique name, and therefore avoids conflicts even when multiple repositories are being cloned concurrently.