Skip to content

fix: Potential fix for code scanning alert no. 75: Uncontrolled data used in path expression #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 16, 2025
Merged

fix: Potential fix for code scanning alert no. 75: Uncontrolled data used in path expression #421

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62634b3
Potential fix for code scanning alert no. 75: Uncontrolled data used …
filipchristiansen Jul 15, 2025
5090e02
Update src/server/routers/ingest.py
filipchristiansen Jul 15, 2025
0fed34a
Update src/server/routers/ingest.py
filipchristiansen Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/server/routers/ingest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,10 @@ async def download_ingest(ingest_id: str) -> FileResponse:
- **HTTPException**: **403** - the process lacks permission to read the directory or file

"""
directory = TMP_BASE_PATH / ingest_id
# Normalize and validate the directory path
directory = (TMP_BASE_PATH / ingest_id).resolve()
if not str(directory).startswith(str(TMP_BASE_PATH.resolve())):
raise HTTPException(status_code=status.HTTP_403_FORBIDDEN, detail=f"Invalid ingest ID: {ingest_id!r}")

if not directory.is_dir():
raise HTTPException(status_code=status.HTTP_404_NOT_FOUND, detail=f"Digest {ingest_id!r} not found")
Expand Down
Loading