Skip to content

fix: Potential fix for code scanning alert no. 75: Uncontrolled data used in path expression #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 16, 2025
Merged

fix: Potential fix for code scanning alert no. 75: Uncontrolled data used in path expression #421

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62634b3
Potential fix for code scanning alert no. 75: Uncontrolled data used …
filipchristiansen Jul 15, 2025
5090e02
Update src/server/routers/ingest.py
filipchristiansen Jul 15, 2025
0fed34a
Update src/server/routers/ingest.py
filipchristiansen Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/server/routers/ingest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,11 @@
- **HTTPException**: **403** - the process lacks permission to read the directory or file
"""
# Normalize and validate the directory path
directory = TMP_BASE_PATH / ingest_id
directory = directory.resolve()

Check failure

Code scanning / CodeQL

Uncontrolled data used in path expression High

This path depends on a
user-provided value
Loading
.

Copilot Autofix

AI 3 months ago

To fix the issue, we need to ensure that the constructed path (directory) is normalized and validated against the base directory (TMP_BASE_PATH) after normalization. This involves using os.path.realpath or pathlib.Path.resolve() to normalize the path and then verifying that the normalized path starts with the base directory. This ensures that even if the user provides a malicious ingest_id value, the resulting path cannot escape the intended directory.

Steps to implement the fix:

  1. Normalize the path using directory.resolve().
  2. Validate that the normalized path starts with the base directory (TMP_BASE_PATH) using startswith.
  3. Raise an appropriate HTTP exception if the validation fails.
Suggested changeset 1
src/server/routers/ingest.py

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/src/server/routers/ingest.py b/src/server/routers/ingest.py
--- a/src/server/routers/ingest.py
+++ b/src/server/routers/ingest.py
@@ -116,3 +116,6 @@
     directory = TMP_BASE_PATH / ingest_id
-    directory = directory.resolve()
+    try:
+        directory = directory.resolve(strict=True)
+    except FileNotFoundError:
+        raise HTTPException(status_code=status.HTTP_404_NOT_FOUND, detail=f"Digest {ingest_id!r} not found")
     if not str(directory).startswith(str(TMP_BASE_PATH)):
EOF
@@ -116,3 +116,6 @@
directory = TMP_BASE_PATH / ingest_id
directory = directory.resolve()
try:
directory = directory.resolve(strict=True)
except FileNotFoundError:
raise HTTPException(status_code=status.HTTP_404_NOT_FOUND, detail=f"Digest {ingest_id!r} not found")
if not str(directory).startswith(str(TMP_BASE_PATH)):
Copilot is powered by AI and may make mistakes. Always verify output.
Unable to commit as this autofix suggestion is now outdated
if not str(directory).startswith(str(TMP_BASE_PATH)):
raise HTTPException(status_code=status.HTTP_403_FORBIDDEN, detail=f"Invalid ingest ID: {ingest_id!r}")

if not directory.is_dir():
raise HTTPException(status_code=status.HTTP_404_NOT_FOUND, detail=f"Digest {ingest_id!r} not found")
Expand Down
Loading