Feature/define globs #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nytopop
reviewed
Oct 24, 2017
| "github.com/knq/dburl" | ||
| "github.com/codercom/xo/internal" | ||
| "github.com/codercom/xo/models" | ||
| "github.com/knq/xo/internal" |
There was a problem hiding this comment.
The imports got switched around again, this branch doesn't build without a search / replace.
Author
There was a problem hiding this comment.
you should add this as a remote to the original package ($GOPATH/src/github.com/knq/xo)
There was a problem hiding this comment.
I don't know if this adds much to the discussion, but I used this blog post: http://blog.campoy.cat/2014/03/github-and-go-forking-pull-requests-and.html
There was a problem hiding this comment.
But, yes, in order to get this to work and to maintain compatibility with origin (knq/xo), I added our fork as a remote to my github.com/knq/xo package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is