Skip to content

Published view is not working #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
askdkc opened this issue Sep 30, 2022 · 3 comments
Closed

Published view is not working #8

askdkc opened this issue Sep 30, 2022 · 3 comments

Comments

@askdkc
Copy link
Contributor

askdkc commented Sep 30, 2022

As I mentioned this PR, published view is not used properly it seems.

How to reproduce:

  1. clone this laravel-cev-demo repository
  2. Installing everything by following README instruction
  3. Run php artisan vendor:publish --tag="csv-views"
  4. Edit resources/views/vendor/csv/livewire/tailwindcss/csv-importer.blade.php
  5. access http://Local_URL/customers
  6. Click Import button but import view is not reflecting the edit you made on csv-importer.blade.php at step 4.

Something wrong with this package.

@ousid
Copy link
Member

ousid commented Oct 1, 2022

Hey, @askdkc.
Sorry for the late response, I'll investigate this one today, when I have time.

@askdkc
Copy link
Contributor Author

askdkc commented Oct 11, 2022

Hey, @ousid.

It turns out, this problem is not your code but rather it caused by spatie laravel-package-tools' bug.
So I sent this PR to spatie, in order to fix this bug.
And after it got merged, your package works fine now.

But you need to change the tag name for publishing the view files (because you are using custom view namespace in your code).

So I created this PR.

Hope this helps and close this issue!

@ousid
Copy link
Member

ousid commented Oct 12, 2022

Resolved: #11

@ousid ousid closed this as completed Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants