Bug Fix: package installation failure #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When installing this package to newly created laravel app with "composer require coderflex/laravel-csv" throws an Illuminate\Foundation\ComposerScripts::postAutoloadDump error. I guess removing <?php might be the cause of this.
|
The modification you made, is removing |
|
@ousid Hey did you check it carefully? Please just make sure it works properly. |
|
Ouch! Sorry for that! I didn't check the last PR carefully by @johnwesely, and yeah you're right. |
|
Thank you for your quick review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing this package to newly created laravel app with "composer require coderflex/laravel-csv" throws an Illuminate\Foundation\ComposerScripts::postAutoloadDump error. I guess removing <?php might be the cause of this.