Merge pull request javieraviles#31 from javieraviles/develop

bringing 1.4.1 to master

README.md

@@ -364,6 +364,10 @@ To install or update these dependencies you can use `npm install` or `npm update
 
 ## Changelog
 
+### 1.4.1
+- Fix -> After updating winston to 3.0.0, it was throwing an error when logging errors into file
+- Fix -> Config in config.ts wasn't implementing IConfig interface
+
 ### 1.4.0
 - Dotenv lib updated, no changes needed (they are dropping node4 support)
 - Class-validator lib updated, no chages needed (cool features added like IsPhoneNumber or custom context for decorators)

package.json

@@ -1,6 +1,6 @@
 {
   "name": "node-typescript-koa-rest",
-  "version": "1.4.0",
+  "version": "1.4.1",
   "description": "API REST using NodeJS and KOA framework, typescript. TypeORM for SQL with class-validators. Middlewares JWT, CORS, Winston Logger.",
   "main": "dist/server.js",
   "scripts": {

src/config.ts

@@ -5,13 +5,13 @@ dotenv.config({ path: '.env' });
 export interface IConfig {
     port: number;
     debugLogging: boolean;
-    DbSslConn: boolean;
+    dbsslconn: boolean;
     jwtSecret: string;
     databaseUrl: string;
 }
 
-const config = {
-    port: process.env.PORT || 3000,
+const config: IConfig = {
+    port: +process.env.PORT || 3000,
     debugLogging: process.env.NODE_ENV == 'development',
     dbsslconn: process.env.NODE_ENV != 'development',
     jwtSecret: process.env.JWT_SECRET || 'your-secret-whatever',

src/logging.ts

@@ -27,15 +27,15 @@ export function logger(winstonInstance) {
         winstonInstance.configure({
             level: config.debugLogging ? 'debug' : 'info',
             transports: [
+                //
+                // - Write all logs error (and below) to `error.log`.
+                new winston.transports.File({ filename: 'error.log', level: 'error' }),
                 //
                 // - Write to all logs with specified level to console.
                 new winston.transports.Console({ format: winston.format.combine(
                     winston.format.colorize(),
                     winston.format.simple()
-                  ) }),
-                //
-                // - Write all logs error (and below) to `error.log`.
-                new winston.transports.File({ filename: 'error.log', level: 'info' })
+                  ) })
             ]
         });