Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #22

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Dev #22

wants to merge 6 commits into from

Conversation

emalorenzo
Copy link
Contributor

No description provided.

emalorenzo and others added 6 commits July 15, 2021 18:25
* Improved ESLint rules, sorting, and using next rules

* sending with error

* testing husky

* should fail

* should be fixed now

* added eslint fix command on pre-commit with husky

* improved prettier config

* merged tsconfig with jsconfig

* removed unnecesary vscode config and added default project vscode settings

* removed codesandbox config

* lock dependencies

* lint

* fix mdx images

Co-authored-by: Tomas Discoli <tomas.discoli@scale.com>
@emalorenzo emalorenzo requested a review from tomasdisk July 29, 2021 20:08
@vercel
Copy link

vercel bot commented Jul 29, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/coderhood/coderhood/AyrqLi6NzGk2MtTsdZYjkJNW42GP
✅ Preview: https://coderhood-git-dev-coderhood.vercel.app

#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

yarn eslint --fix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No me gusta que te edite el codigo sin que te des cuenta 😕
como prefieras, no es nada grave igual xD

Suggested change
yarn eslint --fix
yarn eslint

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buen punto eh, tenes razon banco también que no hayan sorpresas

],
"private": false,
"scripts": {
"lint": "yarn prettier && yarn eslint",
"eslint": "eslint --max-warnings 20 'src/**/*.{js,jsx}' --ext jsconfig.json",
"eslint-fix": "eslint --fix 'src/**/*.{js,jsx}' --ext jsconfig.json",
"eslint": "eslint --max-warnings 50 'src/**/*.{js,jsx,ts,tsx}' --ext tsconfig.json",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

50 👀
Lol cada vez mas grande!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jajaja era para que me deje pushear y me colgué. Lo tengo que sacar 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants