Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat (or bug?): Allow Enter key event on a masked input #67

Closed
stephannv opened this issue Jan 11, 2024 · 2 comments
Closed

feat (or bug?): Allow Enter key event on a masked input #67

stephannv opened this issue Jan 11, 2024 · 2 comments
Assignees
@codermarcos
Labels
bug A confirmed bug

Comments

@stephannv
Copy link
Contributor

Pressing enter on an masked input isn't submitting the form.

I'm using 4.1.0 version.

To reproduce save this as a html and open it on a browser. Try to press enter on masked input and then try to press enter on not masked input:

<!DOCTYPE html>
<html lang="en">
<head>
  <meta charset="UTF-8">
  <meta name="viewport" content="width=device-width, initial-scale=1.0">
  <title>Document</title>
  <script src="https://github.com/codermarcos/simple-mask-money/releases/download/v4.1.0/simple-mask-money.umd.js"></script>

</head>
<body>
  <form action="https://www.google.com">
    <label for="my-input">Masked input (enter doesn't work)</label>
    <input type="text" id="my-input">

    <br>
    <br>

    <label for="other-input">Not masked input (enter works)</label>
    <input type="text" id="other-input" placeholder="press enter here">

    <input type="submit" value="Submit">
  </form>

  <script>
    SimpleMaskMoney.setMask('#my-input');
  </script>
</body>
</html>
@codermarcos codermarcos self-assigned this Jan 27, 2024
@codermarcos codermarcos added the bug A confirmed bug label Jan 27, 2024
codermarcos added a commit that referenced this issue Jan 28, 2024
@codermarcos
🐛 fix input set mask behaviour to form submit
9f5a358 
On branch fix/#67/problem-input-behaviour
Changes to be committed:
	modified:   cypress/e2e/v4.x.x/set-mask.cy.ts
	modified:   src/set-mask.ts
codermarcos added a commit that referenced this issue Jan 28, 2024
@codermarcos
🔀 Merge branch 'main' of github.com:codermarcos/simple-mask-money int…
2252bcc 
…o fix/#67/problem-input-behaviour

Conflicts:
	src/set-mask.ts

On branch fix/#67/problem-input-behaviour
All conflicts fixed but you are still merging.
Changes to be committed:
	modified:   package-lock.json
	modified:   package.json
	modified:   src/get-base-configuration.ts
	modified:   src/set-mask.ts
	modified:   src/types.ts
	modified:   tests/get-base-configuration.test.ts
codermarcos added a commit that referenced this issue Jan 28, 2024
@codermarcos
🔀 Merge branch 'main' of github.com:codermarcos/simple-mask-money int…
26727ac 
…o fix/#67/problem-input-behaviour

Conflicts:
	src/set-mask.ts

On branch fix/#67/problem-input-behaviour
All conflicts fixed but you are still merging.

Changes to be committed:
	modified:   package-lock.json
	modified:   package.json
	modified:   src/set-mask.ts
@codermarcos codermarcos mentioned this issue Jan 28, 2024
Merged
1 task
@codermarcos codermarcos moved this to Doing in Tasks Jan 28, 2024
codermarcos added a commit that referenced this issue Jan 28, 2024
@codermarcos
🔀 Merge pull request #69 from codermarcos/fix/#67/problem-input-behav…
cc06f6e 
…iour

🐛 Fix problem input behaviour
@codermarcos
Copy link
Owner

Thank you very much for your issue we need more developers as you ❤️
It should be fixed at the version 4.1.2. Could you check please?

@codermarcos codermarcos moved this from Doing to Waiting response in Tasks Jan 28, 2024
@stephannv
Copy link
Contributor Author

Thanks, I appreciate your effort with this project.

I already upgrade simple-mask-money to 4.1.2 on my project, and this issue is fixed now. Thanks again.

@codermarcos codermarcos moved this from Waiting response to Done in Tasks Jan 28, 2024
codermarcos added a commit that referenced this issue Aug 23, 2024
@codermarcos
🐛 fix input set mask behaviour to form submit
700ee72 
On branch fix/#67/problem-input-behaviour
Changes to be committed:
	modified:   cypress/e2e/v4.x.x/set-mask.cy.ts
	modified:   src/set-mask.ts
codermarcos added a commit that referenced this issue Aug 23, 2024
@codermarcos
🔀 Merge branch 'main' of github.com:codermarcos/simple-mask-money int…
d6fe029 
…o fix/#67/problem-input-behaviour

Conflicts:
	src/set-mask.ts

On branch fix/#67/problem-input-behaviour
All conflicts fixed but you are still merging.
Changes to be committed:
	modified:   package-lock.json
	modified:   package.json
	modified:   src/get-base-configuration.ts
	modified:   src/set-mask.ts
	modified:   src/types.ts
	modified:   tests/get-base-configuration.test.ts
codermarcos added a commit that referenced this issue Aug 23, 2024
@codermarcos
🔀 Merge branch 'main' of github.com:codermarcos/simple-mask-money int…
2e3c3a1 
…o fix/#67/problem-input-behaviour

Conflicts:
	src/set-mask.ts

On branch fix/#67/problem-input-behaviour
All conflicts fixed but you are still merging.

Changes to be committed:
	modified:   package-lock.json
	modified:   package.json
	modified:   src/set-mask.ts
codermarcos added a commit that referenced this issue Aug 23, 2024
@codermarcos
🔀 Merge pull request #69 from codermarcos/fix/#67/problem-input-behav…
2760862 
…iour

🐛 Fix problem input behaviour
codermarcos added a commit that referenced this issue Aug 23, 2024
@codermarcos
🐛 fix input set mask behaviour to form submit
4a23a31 
On branch fix/#67/problem-input-behaviour
Changes to be committed:
	modified:   cypress/e2e/v4.x.x/set-mask.cy.ts
	modified:   src/set-mask.ts
codermarcos added a commit that referenced this issue Aug 23, 2024
@codermarcos
🔀 Merge branch 'main' of github.com:codermarcos/simple-mask-money int…
a1f5f48 
…o fix/#67/problem-input-behaviour

Conflicts:
	src/set-mask.ts

On branch fix/#67/problem-input-behaviour
All conflicts fixed but you are still merging.
Changes to be committed:
	modified:   package-lock.json
	modified:   package.json
	modified:   src/get-base-configuration.ts
	modified:   src/set-mask.ts
	modified:   src/types.ts
	modified:   tests/get-base-configuration.test.ts
codermarcos added a commit that referenced this issue Aug 23, 2024
@codermarcos
🔀 Merge branch 'main' of github.com:codermarcos/simple-mask-money int…
1918c6e 
…o fix/#67/problem-input-behaviour

Conflicts:
	src/set-mask.ts

On branch fix/#67/problem-input-behaviour
All conflicts fixed but you are still merging.

Changes to be committed:
	modified:   package-lock.json
	modified:   package.json
	modified:   src/set-mask.ts
codermarcos added a commit that referenced this issue Aug 23, 2024
@codermarcos
🔀 Merge pull request #69 from codermarcos/fix/#67/problem-input-behav…
6ff3bb6 
…iour

🐛 Fix problem input behaviour
@stephannv stephannv mentioned this issue Dec 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codermarcos codermarcos

Labels
bug A confirmed bug
Projects
Tasks
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stephannv @codermarcos