🐛 Fix readonly inputs #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On branch main Changes to be committed: modified: README.md
On branch fix/#63/readonly-inputs Changes to be committed: modified: cypress/e2e/v4.x.x/set-mask.cy.ts modified: cypress/file/index.html modified: src/set-mask.ts modified: tests/set-mask.test.ts
On branch fix/#63/readonly-inputs Changes to be committed: modified: CONTRIBUTING.md
…o fix/#63/readonly-inputs Conflicts: src/set-mask.ts On branch fix/#63/readonly-inputs All conflicts fixed but you are still merging. Changes to be committed: modified: package-lock.json modified: package.json modified: src/get-base-configuration.ts modified: src/set-mask.ts modified: src/types.ts modified: tests/get-base-configuration.test.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR should fix issue #63 which allow the user type something when input is readonly.
Thanks to @robsontenorio for report it.
In addition this PR should improve our documentation.
🧪 How to validate
Run the application locally:
🏷️ Related tasks
🗃️ Changes
On branch:
Changes to be committed: