-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for EXTERNAL auth #213
Conversation
Hello, thanks for opening this PR! We will give you a feedback in the next few days |
Just about to head on vacation, so I will be able to make these updates in a few weeks. |
Is there a way I can run these github actions on my own account? I have not used github actions before, so not familiar with them. Plus I seem to be in a different timezone making it challenging to work on it while you are available. |
Hello David, I think you need to enable Actions in your forked repository by visiting the "Actions" tab. You should see a warning with a button to enable workflows. Here is a discussion regarding this https://github.com/orgs/community/discussions/50736 Thanks again! |
Thanks for the pointers, the workflow should now be working as expected. |
We'll give you a feedback as soon as possible. Thanks! |
@david-mohr Thank for the PR I have added two small comments. WDYT about it? |
Co-authored-by: GPad <642430+gpad@users.noreply.github.com>
@gpad thanks, updates applied |
@icappello just curious, do you have an eta on the next release? Happy using my fork for now, but wanted to follow up before I forget. Thanks! |
Adds an optional
mechanism
parameter and implements EXTERNAL auth following the Java reference implementation.Also fixes a broken test.