Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for EXTERNAL auth #213

Merged
merged 9 commits into from
Nov 7, 2024

Conversation

david-mohr
Copy link
Contributor

Adds an optional mechanism parameter and implements EXTERNAL auth following the Java reference implementation.

Also fixes a broken test.

@icappello
Copy link
Member

Hello, thanks for opening this PR! We will give you a feedback in the next few days

src/connection.ts Outdated Show resolved Hide resolved
test/support/util.ts Outdated Show resolved Hide resolved
@david-mohr
Copy link
Contributor Author

Just about to head on vacation, so I will be able to make these updates in a few weeks.

@david-mohr
Copy link
Contributor Author

Is there a way I can run these github actions on my own account? I have not used github actions before, so not familiar with them. Plus I seem to be in a different timezone making it challenging to work on it while you are available.

@icappello
Copy link
Member

Hello David, I think you need to enable Actions in your forked repository by visiting the "Actions" tab. You should see a warning with a button to enable workflows.

Here is a discussion regarding this https://github.com/orgs/community/discussions/50736

Thanks again!

@david-mohr
Copy link
Contributor Author

Thanks for the pointers, the workflow should now be working as expected.

@icappello icappello requested review from tarzacodes and l4mby October 31, 2024 10:06
@icappello
Copy link
Member

We'll give you a feedback as soon as possible.

Thanks!

src/client.ts Outdated Show resolved Hide resolved
@gpad
Copy link
Contributor

gpad commented Nov 6, 2024

@david-mohr Thank for the PR I have added two small comments. WDYT about it?

david-mohr and others added 2 commits November 7, 2024 08:02
Co-authored-by: GPad <642430+gpad@users.noreply.github.com>
@david-mohr
Copy link
Contributor Author

@gpad thanks, updates applied

@icappello icappello merged commit d8083e5 into coders51:main Nov 7, 2024
2 checks passed
@david-mohr
Copy link
Contributor Author

@icappello just curious, do you have an eta on the next release? Happy using my fork for now, but wanted to follow up before I forget. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants