260 refactoring: manage connections inside pool #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jun 13, 2025
tarzacodes
reviewed
Jun 16, 2025
tarzacodes
reviewed
Jun 16, 2025
tarzacodes
previously approved these changes
Jun 16, 2025
Contributor
tarzacodes
left a comment
tarzacodes
left a comment
There was a problem hiding this comment.
Still on the fence on the manuallyClose stuff, but as it has been mentioned that that will be tackled in a subsequent PR, approving! Loving the rest of the work, stuff is starting to look and feel way cleaner, thanks 🔥
albertobarrila
approved these changes
Jun 17, 2025
apietroni51
deleted the
260-refactoring-as-a-developer-i-want-to-manage-connections-inside-the-pool
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far we kept the
manuallyCloseparam, but therefCountand connection caching are managed inside theConnectionPool.