Skip to content

hotfix replace carbon parse with createFromFormat #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

hotfix replace carbon parse with createFromFormat #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
601d53a
hotfix replace carbon parse with createFromFormat
shabayekdes Apr 6, 2020
b94b7ae
Add validation request date format
shabayekdes Apr 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/Author.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@ class Author extends Model

public function setDobAttribute($dob)
{
$this->attributes['dob'] = Carbon::parse($dob);
$this->attributes['dob'] = Carbon::createFromFormat('m/d/Y', $dob);
}
}
2 changes: 1 addition & 1 deletion app/Http/Controllers/AuthorsController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ protected function validateRequest()
{
return request()->validate([
'name' => 'required',
'dob' => 'required',
'dob' => 'required|date_format:m/d/Y',
]);
}
}
2 changes: 2 additions & 0 deletions tests/Feature/AuthorManagementTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ class AuthorManagementTest extends TestCase
/** @test */
public function an_author_can_be_created()
{
$this->withoutExceptionHandling();

$this->post('/authors', $this->data());

$author = Author::all();
Expand Down