-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(genie): allow genie to sort wishes properly #1013
Conversation
One of the cool things about genie is it's sorting algorithm takes into account the user's previous choices. By providing the input value when you make the wish, genie can keep track of what input values lead to which wishes and can optimistically suggest certain wishes as the user's typing.
I looked at the deployed version of the PR and it appears that this isn't working still but I don't think sourcemaps are working because I can't debug like I can in the production app. Any ideas? |
Ah, I've worked it out. The |
Sweet! It's working! Next step will be to save genie's options to localstorage whenever a wish is made and then rehydrate genie when the component is mounted... |
After this the next thing we'll need to do is figure out why the ⌘ + p keyboard shortcut doesn't seem to open the menu most the time... |
Sweet, this thing's totally working! So now genie will be able to learn the user's preferred wishes as they type, making the menu more helpful. This is ready to be merged! |
Woooooooow this is greaaaat! Thank you so much @kentcdodds! Merging this in now. Such an improvement! |
One of the cool things about genie is it's sorting algorithm takes into account the user's previous choices. By providing the input value when you make the wish, genie can keep track of what input values lead to which wishes and can optimistically suggest certain wishes as the user's typing.
What kind of change does this PR introduce? Bug Fix
What is the current behavior? genie isn't able to make proper suggestions based on previous wishes made
What is the new behavior? genie will optimistically suggest wishes
Checklist: