Skip to content

Add *.css to sideEffects #1133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Add *.css to sideEffects #1133

merged 1 commit into from
Oct 1, 2018

Conversation

pomber
Copy link
Contributor

@pomber pomber commented Sep 30, 2018

Hi! I started using react-sandpack with Webpack 4 (CRA v2) and loading react-smooshpack/dist/styles.css is broken in production mode. The problem seems to be the sideEffects in package.json.
More info:

@CompuIves
Copy link
Member

That makes sense, thanks for the contribution!

@CompuIves CompuIves merged commit bcd8383 into codesandbox:master Oct 1, 2018
mike-north pushed a commit to mike-north/codesandbox-client that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants