-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Curator page #1326
Merged
Merged
Curator page #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CompuIves
approved these changes
Nov 23, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super clean! I like the code, I left some small comments/questions. Would be ready to merge this regardless.
packages/app/src/app/pages/common/Modals/PickSandboxModal/index.js
Outdated
Show resolved
Hide resolved
4304838
to
11f05f1
Compare
* Custom template * Bump * Reset compilation when config of modules change * Fix null sandpackconfig * Remove double setup * Bump * Make optimization of cache optional * Bump * Don't save cache on smoosh * BUMP * Add module mockgp * Version bump * Fix package json version resolving * Bump * mock modulke * Fix module * Bump to 0.0.45 * Fix typing problem * Fix new build step * Version bump * Remove console.log * Bump version * Async file resolving * Remote messaging system * Add remote file resolving * Bump version * Remove comments * Allow dynamic import in ESModule dependencies * Also add dynamic syntax to parser opts * Fix custom template resetting for new manager * Bump * Bump * Upgrade codesandbox-api * Fix typings * Fix getCodeSandboxURL * Bump version * Fix merge conflict * Add babel transpiler * New version bump * Update locks * Publish new codesandbox-api * Bump sandpack * Update codesandbox-api * Add button for disabling button * Add option to manager * Bump * Rename vscode-editor * Disable shadows altogether in SSE loading screen
11f05f1
to
9d8147e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Adds curator page