-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add animation when sub-modes disappear in the header #145
Merged
CompuIves
merged 2 commits into
codesandbox:master
from
jseminck:transition-editor-screens
Aug 24, 2017
Merged
Add animation when sub-modes disappear in the header #145
CompuIves
merged 2 commits into
codesandbox:master
from
jseminck:transition-editor-screens
Aug 24, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was really interesting and fun to read, really nice work on the writeup and the animation! I indeed didn't do the fade out because it was a complicated thing to solve, and I'm really glad to see that you solved it. I'll merge this in now, thanks for your help on this. Very impressive. |
This was referenced Apr 25, 2021
This was referenced Sep 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the things which I absolutely like about Code Sandbox is that it has a lot of fast smooth transitions in the UI. Actually, I have found inspiration from your work and applied to it to my own works, so thanks for that! 😄
One small thing disturbed me though. There's a very nice animation when hovering over the current mode to show the sub-modes, but there is no "leaving" animation:
I tried adding a leaving animation (first commit). It wasn't that hard, and worked fine initially:
However, I quickly discovered a nasty side effect: the mode changes instantly, so when clicking a mode, it looks a bit weird:
I tried two things:
I think I understood why there was no animation (yet?) as it wasn't easy to find something that works nicely. But I think the above approach works quite well and looks quite nice. I don't know if this is something you want, but if you do feel free. It was at least fun to look into this. 😄