Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigate between featured sandboxes using left and right arrow keys #1452

Merged
merged 1 commit into from
Jan 10, 2019

Conversation

Chiamaka
Copy link
Contributor

@Chiamaka Chiamaka commented Jan 10, 2019

What kind of change does this PR introduce?
Feature

What is the current behavior?
The featured sandboxes on the explore page can only be changed by clicking the right and left arrow

What is the new behavior?
This change allows a user navigate the featured sandboxes by pressing the arrow keys on the keyboard

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

@SaraVieira
Copy link
Contributor

hey !

I am sorry, I don't understand what this adds, when you open a modal you can already navigate using the arrows

@Chiamaka
Copy link
Contributor Author

Hey @SaraVieira
Not when you open the modal. This is the page I'm referring to :)

screenshot_2019-01-10_at_7_41_06_pm

@SaraVieira
Copy link
Contributor

OHHHH!

That is cool! Merged!

Thank you for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants