Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose common types on types package #1822

Merged
merged 1 commit into from
Apr 29, 2019
Merged

Conversation

christianalfoni
Copy link
Contributor

@christianalfoni christianalfoni commented Apr 29, 2019

This is a preparation for Typescript refactor.

  • The common/src/types.ts file is moved to common/src/types/index.ts
  • The tsconfig.json of app now has a shortcut path named "types" to this moved file

This allows ut to put all typings in a single folder and expose them through ../types/index.ts. It also allows to import any type by:

import { Sandbox, Module } from 'types'

I think this will clean up a lot and make things more consistent, also preventing duplicate typing. All application wide types should be defined in this folder so you always know where to look :-)

@CompuIves
Copy link
Member

Beautiful!

@CompuIves CompuIves merged commit 8a345d3 into master Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants