expose common types on types package #1822
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preparation for Typescript refactor.
common/src/types.ts
file is moved tocommon/src/types/index.ts
tsconfig.json
of app now has a shortcut path named "types" to this moved fileThis allows ut to put all typings in a single folder and expose them through
../types/index.ts
. It also allows to import any type by:I think this will clean up a lot and make things more consistent, also preventing duplicate typing. All application wide types should be defined in this folder so you always know where to look :-)