Skip to content

Conversation

@christianalfoni
Copy link
Contributor

@christianalfoni christianalfoni commented Apr 29, 2019

This is a preparation for Typescript refactor.

  • The common/src/types.ts file is moved to common/src/types/index.ts
  • The tsconfig.json of app now has a shortcut path named "types" to this moved file

This allows ut to put all typings in a single folder and expose them through ../types/index.ts. It also allows to import any type by:

import { Sandbox, Module } from 'types'

I think this will clean up a lot and make things more consistent, also preventing duplicate typing. All application wide types should be defined in this folder so you always know where to look :-)

@CompuIves
Copy link
Member

Beautiful!

@CompuIves CompuIves merged commit 8a345d3 into master Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants