Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeScript errors #1986

Merged
merged 2 commits into from
May 28, 2019
Merged

Fix TypeScript errors #1986

merged 2 commits into from
May 28, 2019

Conversation

MichaelDeBoey
Copy link
Contributor

What kind of change does this PR introduce?
Fix TypeScript errors

What is the current behavior?
yarn typescheck runs with errors

What is the new behavior?
yarn typescheck runs without errors

Checklist:

  • Documentation N/A
  • Tests
  • Ready to be merged
  • Added myself to contributors table N/A

@lbogdan
Copy link
Contributor

lbogdan commented May 28, 2019

@MichaelDeBoey Can you please rebase this to master, I just committed a fix for the other integration tests failures. Thanks!

@MichaelDeBoey
Copy link
Contributor Author

@lbogdan Done 😉

@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented May 28, 2019

@CompuIves Al discussions are resolved 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants