Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toggle freeze state on customTemplates #2479

Merged
merged 1 commit into from
Sep 27, 2019

Conversation

yeion7
Copy link
Contributor

@yeion7 yeion7 commented Sep 20, 2019

What kind of change does this PR introduce?

fix

What is the current behavior?

When you turn off the forzen behavior of custom templates, you can't turn on again

What is the new behavior?

You can switch the freeze state

What steps did you take to test this?

Before:

ClA6mA0F2R

After:

wNEj2mdWzA

Checklist

  • Documentation
  • Testing
  • Ready to be merged
  • Added myself to contributors table

@vercel
Copy link

vercel bot commented Sep 20, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://codesandbox-client-git-fork-yeion7-fix-toggle-freeze.codesandbox1.now.sh

@vercel vercel bot temporarily deployed to staging September 20, 2019 17:23 Inactive
Copy link
Contributor

@christianalfoni christianalfoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent stuff! Thanks so much for contributing! :)

Copy link
Contributor

@SaraVieira SaraVieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again!

Super nice fix

@SaraVieira SaraVieira merged commit 400bf0a into codesandbox:master Sep 27, 2019
yeion7 added a commit to yeion7/codesandbox-client that referenced this pull request Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants