Notifications, showing, short selector a11y #2711
Conversation
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://codesandbox-client-git-fork-yeion7-notifications-a11y.codesandbox1.now.sh |
yeion7
changed the title
|
@CompuIves I've reopened this from #2652, maybe we could find a solution for outline styles and merge this change, sorry for the prev PR Could you check if the z-index and performance issues persist after upgrade |
|
This is the current outline, maybe we could define a better outline style or maybe change the item background on hover
|
yeion7
force-pushed
the
notifications-a11y
branch
from
d2de254 to
ac8f7d1
Compare
yeion7
changed the title
|
@CompuIves what do you think about this? use the same styles as user menu on hover items |
|
Read on the other PR that there was some performance issue! Is this still an issue? If so, please let me know if there's anything I can help with on the Reakit side. :) |
|
@CompuIves any chance of moving this PR forward? |
…to notifications-a11y
|
Build for latest commit 435bc57 is at https://pr2711.build.csb.dev/s/new. |
What kind of change does this PR introduce?
Refactor, reopen #2652
What is the current behavior?
The notifications has a few a11 issues
What is the new behavior?
What steps did you take to test this?
Checklist