🔨 Refactored, 🧠 Overmind, Hacktober | Refactor PreviewSettings to use overmind #2758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/codesandbox/codesandbox-client/2pte1it3q |
milap1296
force-pushed
the
refactor-EditorPageSettings-PreviewSettings
branch
from
3633103 to
5dca4bf
Compare
milap1296
changed the title
milap1296
changed the title
84 tasks
milap1296
force-pushed
the
refactor-EditorPageSettings-PreviewSettings
branch
from
5dca4bf to
7e864b8
Compare
Saeris
added
Hacktoberfest
🔨 Refactor
🧠 Overmind
|
@christianalfoni can you please review this too? |
|
Build for latest commit 7430d5b is at https://pr2758.build.csb.dev/s/new. |
|
Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔨 Refactored, 🧠 Overmind, Hacktober | Refactor PreviewSettings to use overmind
What kind of change does this PR introduce?
Refactors code as a part of hacktoberfest mentioned in #2621.
@Saeris @christianalfoni @SaraVieira
What is the current behavior?
app/pages/common/Modals/PreferencesModal/EditorPageSettings/PreviewSettings/index.tsxwas using inject and hooksObserver from app/componentConnectors.What is the new behavior?
Refactored PreviewSettings to FC and replaced inject, hookObserver with useOvermind
What steps did you take to test this? This is required before we can merge.
Checklist