Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor, 🧠 Overmind | pages/common/Modals/DeleteProfileSandboxModal to use Overmind #2762

Conversation

Infi-Knight
Copy link
Contributor

What kind of change does this PR introduce?

Refactors code as a part of hacktoberfest mentioned in #2621.
@Saeris @christianalfoni

What is the current behavior?

app/pages/common/Modals/DeleteProfileSandboxModal was using Cerebral

What is the new behavior?

DeleteProfileSandboxModal now uses useOvermind hook from the new state management tool, Overmind.

What steps did you take to test this? This is required before we can merge.

  1. Replaced inject and hooksObserver with useOvermind
  2. Ran yarn test
  3. Manually tested the component by creating a new sandbox and loggin using auth token and then deleting the sandbox.
  4. Ran yarn lint

Checklist

  • Documentation: N/A
  • Testing
  • Ready to be merged
  • Added myself to contributors table

@vercel vercel bot temporarily deployed to staging October 13, 2019 12:20 Inactive
@vercel
Copy link

vercel bot commented Oct 13, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/codesandbox/codesandbox-client/pgo1sotf3
🌍 Preview: https://codesandbox-cl-git-fork-infi-knight-refactor-common-dele-e224be.codesandbox1.now.sh

@vercel vercel bot temporarily deployed to staging October 13, 2019 17:06 Inactive
@Saeris Saeris added Hacktoberfest 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Oct 14, 2019
@MichaelDeBoey
Copy link
Contributor

This is a duplicate of #2744

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants