(fix) Allow to enable vimmode for Chrome on iOS. #3700
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build for latest commit 419c808 is at https://pr3700.build.csb.dev/s/new. |
|
Interesting. In Chrome we get the same error message as in Safari on iPadOS. Related to #1704.
|
|
That's very interesting. The reason that the vim extension is not working right now is because it uses a RegEx feature of V8 specifically. I opened a PR for removing this, but I should check the status of that and maybe update the extension. |
|
Hey! The issue is tha5t chrome on iOS is basically a skinned safari so we are still not supposed to show it because of the expression ives talked about Sorry :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix for #3699.
What is the current behavior?
See #3699.
What is the new behavior?
Enables vimmode settings option for Chrome on iPadOS.
What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.
Checklist