Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ability to close the multi comment selector #3793

Merged
merged 4 commits into from
Mar 31, 2020
Merged

Add Ability to close the multi comment selector #3793

merged 4 commits into from
Mar 31, 2020

Conversation

SaraVieira
Copy link
Contributor

@SaraVieira SaraVieira commented Mar 30, 2020 •
edited
Loading

  • Ability to close the multi comment selector

@lbogdan lbogdan temporarily deployed to pr3793 March 30, 2020 18:05 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Mar 30, 2020 •
edited
Loading

Build for latest commit 6136607 is at https://pr3793.build.csb.dev/s/new.

@DannyRuchtie
Copy link
Contributor

Is the x needed?
Implementation is different from design.
If x is needed then I would like to tweak it a bit

@SaraVieira
Copy link
Contributor Author

@DannyRuchtie Remove the X and now closes on outside click

@lbogdan lbogdan temporarily deployed to pr3793 March 30, 2020 21:18 Inactive
@SaraVieira SaraVieira changed the title add close to multi comment Add Ability to close the multi comment selector Mar 30, 2020
christianalfoni
christianalfoni approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@christianalfoni christianalfoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! ❤️

@christianalfoni christianalfoni merged commit d34292d into master Mar 31, 2020
@christianalfoni christianalfoni deleted the close-multi-selector branch March 31, 2020 05:32
@adamlaska adamlaska mentioned this pull request Nov 26, 2023
Open
@adamlaska adamlaska mentioned this pull request May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianalfoni christianalfoni christianalfoni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SaraVieira @lbogdan @DannyRuchtie @christianalfoni