-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add template copy link #3936
Merged
SaraVieira
merged 1 commit into
codesandbox:master
from
jyash97:feat/add-template-copy-link
Apr 18, 2020
Merged
feat: add template copy link #3936
SaraVieira
merged 1 commit into
codesandbox:master
from
jyash97:feat/add-template-copy-link
Apr 18, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build for latest commit 8d41d1e is at https://pr3936.build.csb.dev/s/new. |
SaraVieira
reviewed
Apr 18, 2020
@@ -404,7 +404,7 @@ class SandboxItemComponent extends React.PureComponent<Props, State> { | |||
|
|||
copySandboxURL = () => { | |||
const url = sandboxUrl({ id: this.props.id, alias: this.props.alias }); | |||
|
|||
// TODO: Use effects.browse.copyToClipboard after refactoring to Function Component |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank you!
SaraVieira
approved these changes
Apr 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thank you so much!
Thanks for the quick review. 💯 |
This was referenced Sep 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature 🌈
What is the current behavior?
Currently, we don't have a copy link option in the context menu
What is the new behavior?
Add option to copy link
What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.
Checklist