Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix File UI #3972

Merged
merged 2 commits into from
Apr 22, 2020
Merged

Fix File UI #3972

merged 2 commits into from
Apr 22, 2020

Conversation

SaraVieira
Copy link
Contributor

@SaraVieira SaraVieira commented Apr 22, 2020 •
edited
Loading

Fixes the File UI for prettier and sandbox config crashing

Also removes the late who-uses-codesandbox page

closes #3966

@SaraVieira SaraVieira requested a review from CompuIves April 22, 2020 14:08
CompuIves
CompuIves requested changes Apr 22, 2020
View reviewed changes
Copy link
Member

@CompuIves CompuIves left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! Maybe it would be a bit cleaner to add it to the component that renders the config page instead, here:

https://github.com/codesandbox/codesandbox-client/blob/master/packages/app/src/app/components/CodeEditor/VSCode/Configuration/index.tsx#L151-L155.

Then we have less code to change.

@lbogdan lbogdan temporarily deployed to pr3972 April 22, 2020 14:14 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Apr 22, 2020 •
edited
Loading

Build for latest commit 7180e56 is at https://pr3972.build.csb.dev/s/new.

@CompuIves CompuIves self-requested a review April 22, 2020 14:34
@CompuIves CompuIves merged commit b60a4ef into master Apr 22, 2020
@CompuIves CompuIves deleted the fix-ui branch April 22, 2020 14:34
This was referenced Feb 11, 2022
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CompuIves CompuIves CompuIves approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to edit sandbox.config.json
3 participants
@SaraVieira @lbogdan @CompuIves