Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard Improvements #3980

Merged
merged 19 commits into from
Apr 28, 2020
Merged

Dashboard Improvements #3980

merged 19 commits into from
Apr 28, 2020

Conversation

SaraVieira
Copy link
Contributor

@SaraVieira SaraVieira commented Apr 23, 2020 •
edited
Loading

This PR does more than it should but I couldn't stop:

  • Moves all queries to overmind
  • Makes actions work after loading dashboard is complete
  • Adds missing info to sandbox card
  • Adds most of the actions on the sandbox card menu
  • Removes loading state
  • Refectches sandboxes on team change

@linear
Copy link

linear bot commented Apr 23, 2020

CSB-101 Creat all Queries and Mutations in State

@lbogdan lbogdan temporarily deployed to pr3980 April 23, 2020 17:41 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Apr 23, 2020 •
edited
Loading

Build for latest commit bbba512 is at https://pr3980.build.csb.dev/s/new.

christianalfoni
christianalfoni requested changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@christianalfoni christianalfoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍 Just a missing type there it seems. Also we need to figure out the type issues here. I took a quick look, but this requires some effort. I might have time later today

packages/app/src/app/overmind/namespaces/dashboard/state.ts Outdated Show resolved Hide resolved
@lbogdan lbogdan temporarily deployed to pr3980 April 24, 2020 10:03 Inactive
@lbogdan lbogdan temporarily deployed to pr3980 April 24, 2020 19:58 Inactive
@lbogdan lbogdan temporarily deployed to pr3980 April 25, 2020 15:45 Inactive
@lbogdan lbogdan temporarily deployed to pr3980 April 26, 2020 18:53 Inactive
@lbogdan lbogdan temporarily deployed to pr3980 April 27, 2020 00:44 Inactive
@lbogdan lbogdan temporarily deployed to pr3980 April 28, 2020 09:41 Inactive
@SaraVieira
Copy link
Contributor Author

SaraVieira commented Apr 28, 2020 •
edited
Loading

closes CSB-101
closes CSB-124
closes CSB-123
closes CSB-122
closes CSB-121
closes CSB-120
closes CSB-119
closes CSB-81

@lbogdan lbogdan temporarily deployed to pr3980 April 28, 2020 10:18 Inactive
@lbogdan lbogdan temporarily deployed to pr3980 April 28, 2020 10:25 Inactive
@lbogdan lbogdan temporarily deployed to pr3980 April 28, 2020 10:42 Inactive
christianalfoni
christianalfoni approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@christianalfoni christianalfoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not gone in all the details, but the overall architecture looks great 👍 😄 Since it is a brand new implementation it should be safe to merge in.

Btw, I believe you can also drop the activeTeam key and whenever changing teams you can do the getPage thing again 😄

@SaraVieira SaraVieira merged commit a35c9d7 into master Apr 28, 2020
@SaraVieira SaraVieira deleted the create-gql branch April 28, 2020 11:21
This was referenced Sep 5, 2021
Open
Open
Open
Closed
Open
Open
Open
Open
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Apr 12, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jun 17, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jul 23, 2022
Open
@adamlaska adamlaska mentioned this pull request Aug 24, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Aug 25, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Nov 21, 2022
Open
@ajesse11x ajesse11x mentioned this pull request Jun 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianalfoni christianalfoni christianalfoni approved these changes

@siddharthkp siddharthkp Awaiting requested review from siddharthkp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SaraVieira @lbogdan @christianalfoni