Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Server screen #4025

Merged

Conversation

MichaelDeBoey
Copy link
Contributor

Things I did:

  • Change deleteEnvironmentVariable's signature to accept a string instead of { name: string }, because it only has 1 argument
  • Change onBrowserFromPortOpened's signature to accept a ServerPort instead of { port: ServerPort }, because it only has 1 argument
  • Make Control, EnvVars, Ports, Server, Status, Tasks & VarForm a FunctionComponent
  • Type VarForm's props
  • Type VarForm's onCancel & onSubmit functions
  • Type the icons
  • Simplify getContainerStatusInfo & getManagerStatusInfo a bit in Status
  • Simplify getIcon a bit in Tasks

@lbogdan lbogdan temporarily deployed to pr4025 April 30, 2020 13:34 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Apr 30, 2020

Build for latest commit b86d805 is at https://pr4025.build.csb.dev/s/new.

@MichaelDeBoey MichaelDeBoey force-pushed the cleanup/screens/Server branch 2 times, most recently from 6190abf to 6154fa3 Compare April 30, 2020 13:59
@lbogdan lbogdan temporarily deployed to pr4025 April 30, 2020 14:17 Inactive
Copy link
Contributor

@SaraVieira SaraVieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey!

Conflicts :(

Can you please not reorder attributes and imports? It makes it super hard to review the PR's as it looks away bigger than it is

@MichaelDeBoey MichaelDeBoey force-pushed the cleanup/screens/Server branch from 6154fa3 to 28e2a7c Compare May 21, 2020 15:45
@MichaelDeBoey MichaelDeBoey requested a review from SaraVieira May 21, 2020 15:47
@lbogdan lbogdan temporarily deployed to pr4025 May 21, 2020 15:51 Inactive
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 21, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b86d805:

Sandbox Source
Notifications Test Configuration

@MichaelDeBoey MichaelDeBoey force-pushed the cleanup/screens/Server branch from 28e2a7c to b0357a2 Compare July 2, 2020 23:01
@MichaelDeBoey
Copy link
Contributor Author

@SaraVieira I've rebased onto upstream/master, so this could be merged now 🙂

@lbogdan lbogdan temporarily deployed to pr4025 July 2, 2020 23:08 Inactive
@SaraVieira
Copy link
Contributor

Restert buttons are not working, gonna pull and see whats up

@MichaelDeBoey
Copy link
Contributor Author

@SaraVieira If needed, I can look at it tomorrow 🙂

@MichaelDeBoey MichaelDeBoey force-pushed the cleanup/screens/Server branch from b0357a2 to c52e421 Compare July 3, 2020 15:18
@lbogdan lbogdan temporarily deployed to pr4025 July 3, 2020 15:26 Inactive
@MichaelDeBoey
Copy link
Contributor Author

@SaraVieira I've rebased onto upstream/master, so this could be merged now 🙂

@SaraVieira SaraVieira merged commit 7d04dad into codesandbox:master Sep 4, 2020
@SaraVieira
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants