-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup Server screen #4025
Cleanup Server screen #4025
Conversation
Build for latest commit b86d805 is at https://pr4025.build.csb.dev/s/new. |
6190abf
to
6154fa3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey!
Conflicts :(
Can you please not reorder attributes and imports? It makes it super hard to review the PR's as it looks away bigger than it is
6154fa3
to
28e2a7c
Compare
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b86d805:
|
28e2a7c
to
b0357a2
Compare
@SaraVieira I've rebased onto |
Restert buttons are not working, gonna pull and see whats up |
@SaraVieira If needed, I can look at it tomorrow 🙂 |
b0357a2
to
c52e421
Compare
c52e421
to
b86d805
Compare
@SaraVieira I've rebased onto |
Thank you! |
Things I did:
deleteEnvironmentVariable
's signature to accept astring
instead of{ name: string }
, because it only has 1 argumentonBrowserFromPortOpened
's signature to accept aServerPort
instead of{ port: ServerPort }
, because it only has 1 argumentControl
,EnvVars
,Ports
,Server
,Status
,Tasks
&VarForm
aFunctionComponent
VarForm
's propsVarForm
'sonCancel
&onSubmit
functionsgetContainerStatusInfo
&getManagerStatusInfo
a bit inStatus
getIcon
a bit inTasks