Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Deployment screen #4026

Merged
merged 1 commit into from
May 25, 2020
Merged

Cleanup Deployment screen #4026

merged 1 commit into from
May 25, 2020

Conversation

MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Apr 30, 2020 •
edited
Loading

Things I did:

  • Change setDeploymentToDelete's signature to accept a string instead of { id: string }, because it only has 1 argument
  • Make Netlify, NotLoggedIn, NotOwner & Vercel a FunctionComponent
  • Type the icons

@lbogdan lbogdan temporarily deployed to pr4026 April 30, 2020 13:34 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Apr 30, 2020 •
edited
Loading

Build for latest commit 4cb596d is at https://pr4026.build.csb.dev/s/new.

@MichaelDeBoey MichaelDeBoey force-pushed the cleanup/screens/Deployment branch 2 times, most recently from 66694b6 to d4d5be9 Compare April 30, 2020 14:02
@lbogdan lbogdan temporarily deployed to pr4026 April 30, 2020 14:18 Inactive
SaraVieira
SaraVieira suggested changes May 18, 2020
View reviewed changes
Copy link
Contributor

@SaraVieira SaraVieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey!

Conflicts :(

Can you please not reorder attributes and imports? It makes it super hard to review the PR's as it looks away bigger than it is

@MichaelDeBoey MichaelDeBoey force-pushed the cleanup/screens/Deployment branch from d4d5be9 to 4ff360f Compare May 21, 2020 16:10
@MichaelDeBoey MichaelDeBoey requested a review from SaraVieira May 21, 2020 16:11
@lbogdan lbogdan temporarily deployed to pr4026 May 21, 2020 16:16 Inactive
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 21, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4cb596d:

Sandbox Source
Notifications Test Configuration

@MichaelDeBoey MichaelDeBoey force-pushed the cleanup/screens/Deployment branch from 4ff360f to 4cb596d Compare May 22, 2020 10:26
@SaraVieira
Copy link
Contributor

Looks good! Thank you!

@SaraVieira SaraVieira merged commit 7baaadd into codesandbox:master May 25, 2020
@MichaelDeBoey MichaelDeBoey deleted the cleanup/screens/Deployment branch May 25, 2020 17:35
This was referenced Feb 11, 2022
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianalfoni christianalfoni Awaiting requested review from christianalfoni

@SaraVieira SaraVieira Awaiting requested review from SaraVieira

Assignees
No one assigned
Labels
🔨 Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelDeBoey @lbogdan @SaraVieira