Skip to content

Delete old dashboard #4556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Stock Analyzer
merged 6 commits into from
Jul 31, 2020
Merged

Delete old dashboard #4556

merged 6 commits into from
Jul 31, 2020

Conversation

@SaraVieira
Copy link
Contributor

@SaraVieira SaraVieira commented Jul 16, 2020 •
edited
Loading

Deletes all the old dashboard and some parts of common that are no longer used

@SaraVieira SaraVieira requested a review from CompuIves July 16, 2020 13:12
@lbogdan lbogdan temporarily deployed to pr4556 July 16, 2020 13:19 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Jul 16, 2020 •
edited
Loading

Build for latest commit bfe50e0 is at https://pr4556.build.csb.dev/s/new.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 16, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bfe50e0:

Sandbox Source
Notifications Test Configuration

@SaraVieira SaraVieira closed this Jul 18, 2020
@MichaelDeBoey MichaelDeBoey deleted the delete-old-dashboard branch July 19, 2020 00:40
@SaraVieira SaraVieira restored the delete-old-dashboard branch July 30, 2020 13:39
@SaraVieira SaraVieira reopened this Jul 30, 2020
@SaraVieira SaraVieira marked this pull request as ready for review July 30, 2020 13:50
@lbogdan lbogdan temporarily deployed to pr4556 July 30, 2020 14:02 Inactive
siddharthkp
siddharthkp approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick glance, looks safe!

CompuIves
CompuIves approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@CompuIves CompuIves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looked at code, looks good to me! 👍

@SaraVieira SaraVieira merged commit e98be23 into master Jul 31, 2020
@SaraVieira SaraVieira deleted the delete-old-dashboard branch July 31, 2020 09:40
@adamlaska adamlaska mentioned this pull request Dec 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CompuIves CompuIves CompuIves approved these changes

+1 more reviewer

@siddharthkp siddharthkp siddharthkp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SaraVieira @lbogdan @CompuIves @siddharthkp