Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix overflow issue in external dependencies #4777

Merged
merged 2 commits into from
Aug 27, 2020
Merged

Conversation

SaraVieira
Copy link
Contributor

Old
CleanShot 2020-08-27 at 16 07 21

New
CleanShot 2020-08-27 at 16 07 15

@SaraVieira SaraVieira requested a review from siddharthkp August 27, 2020 14:08
Copy link
Contributor

@DannyRuchtie DannyRuchtie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lbogdan lbogdan temporarily deployed to pr4777 August 27, 2020 14:14 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Aug 27, 2020

Build for latest commit ed50bfb is at https://pr4777.build.csb.dev/s/new.

@SaraVieira SaraVieira merged commit 2119459 into master Aug 27, 2020
@SaraVieira SaraVieira deleted the fix-overflow-external branch August 27, 2020 15:16
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ed50bfb:

Sandbox Source
Notifications Test Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants